Skip to content

Don't require image/buffer to have COPY_DST to reuse if no data #22632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
beicause wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't require image/buffer to have COPY_DST to reuse if no data #22632

beicause wants to merge 1 commit into from
+10 −8

Conversation

@beicause
Copy link
Contributor

@beicause beicause commented Jan 21, 2026

Objective

If image/buffer don't have data, we won't call write_texture/write_buffer so we can reuse them even if them don't have COPY_DST usage.

Solution

(!had_data || usage contains COPY_DST)

Testing

Manually tested.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Rendering
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@beicause @alice-i-cecile